Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.2 support #2256

Merged
merged 4 commits into from
Jan 22, 2016
Merged

Remove Python 3.2 support #2256

merged 4 commits into from
Jan 22, 2016

Conversation

digitalresistor
Copy link
Member

This removes Python 3.2 support from the testing path, and from setup.py. At this point testing it becomes more difficult because pip no longer installs/runs under Python 3.2, and tox pulls in the latest version of pip.

@digitalresistor
Copy link
Member Author

Closes #2255

Not sure if we want to backport this to 1.5/1.6, but if we don't we need to figure out how install an older version of pip in the Python 3.2 tox environment.

@stevepiercy
Copy link
Member

This PR also needs to include updates to docs. I'm working on those now.

@stevepiercy
Copy link
Member

Docs updated for Pyramid, except for one mention of Waitress running on 3.2+ in docs/glossary.rst.

@stevepiercy
Copy link
Member

From https://www.python.org/dev/peps/pep-0392/#lifespan

...security updates (source only) will be released until 5 years after the release of 3.2 final, which will be February 2016.

I think this should definitely be merged into master for Pyramid 1.7 release.

Since docs for 1.6/latest is the version most hit from search engine results, and pip is where everyone is headed, I'd say backport to 1.6.

For 1.5, I'd say remove testing for 3.2 to get it to pass, but we leave the docs as is to indicate that it runs on 3.2.

Also for future thought, we might want to declare our plan for support of Python 3.3, which is scheduled to cease receiving security updates in September 2017:
https://www.python.org/dev/peps/pep-0398/#lifespan

@digitalresistor digitalresistor added this to the 1.7 milestone Jan 20, 2016
@digitalresistor
Copy link
Member Author

I've added the 1.7 milestone for this. We should definitely add a document somewhere to declare our intentions and how long we will support Python versions. Python 2.6 is kind of a special snowflake, because of CentOS 6.x. It was last released in 2008!!!

@digitalresistor
Copy link
Member Author

@mmerickel I am going to answer your questions on the original ticket here:

pypa/packaging#58

We can use this for Python 3.2 support on Travis, this way we can continue building on travis for 1.5/1.6 branches. Local building becomes a HUGE pain.

@mmerickel
Copy link
Member

I'm much less worried about the complexity of building locally for backports. Anyone who is actually stuck building those versions probably has a machine where it's easier to operate in that enivronment. All backports should be tested via travis using such a fix. Any new features belong on master where we drop 3.2 and local testing is not difficult.

@stevepiercy
Copy link
Member

Is it OK to merge this PR onto master, or is there something else we need to do or are waiting for?

Here's a statement of support of Python, although I don't know where it should go. It might also be a Pylons Project policy.

Python Support Policy

At the time of each release of Pyramid, each version supports all versions of Python to the end of their lifespans. The end-of-life for a given version of Python is when security updates are no longer released.

To determine the Python support for a specific release of Pyramid, view its tox.ini file at the root of the repository.

@digitalresistor
Copy link
Member Author

I don't want to merge this myself, but I am a +1 on merging this asap. I'm leaving it to @mmerickel. We need to apply the fix above for the 1.6-branch and 1.5-branch so that we can continue to build Python 3.2 on Travis for those branches.

@mmerickel
Copy link
Member

We need to apply the fix above for the 1.6-branch and 1.5-branch so that we can continue to build Python 3.2 on Travis for those branches.

Can you add PRs that build for those branches?

@digitalresistor
Copy link
Member Author

Yes, when I get back Monday. I am currently out at SCALE14X.

@digitalresistor
Copy link
Member Author

#2269 #2270

@stevepiercy
Copy link
Member

For "Python Support Policy", how about placing the content here?
http://docs.pylonsproject.org/projects/pyramid/en/latest/narr/upgrading.html#deprecation-and-removal-policy

I also modified the content to point to each branch's tox.ini to find Python support. Much cleaner.

@mmerickel
Copy link
Member

@stevepiercy that seems like a logical place.

mmerickel added a commit that referenced this pull request Jan 22, 2016
@mmerickel mmerickel merged commit 869cd91 into master Jan 22, 2016
@mmerickel mmerickel deleted the remove_py32 branch January 22, 2016 23:02
mmerickel added a commit that referenced this pull request Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants