Feature: JSON exceptions #2489
Merged
Feature: JSON exceptions #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We default to text/plain.
Accept doesn't understand the notation of major/minor masks.
The default is now text/plain, so explicitly set the accept header for what we want to accept.
This simply makes sure we get back the appropriate Content-Type based upon our Accept header.
We also test out the custom formatter that allows the user to change how the JSON is formatted for the exception.
application/json however doesn't have a charset, so we just specify that as UTF-8 for the purpose of encoding the bytes.
This means that to make "text/plain" the default, we need to specifically make it the first thing we offer. For anything else, since the server offers are all weighted equally, the client order should be accepted.
This matches the original code whereby it would return an HTML page if you sent an Accept header of */*.
|
@mmerickel Take a look at this. To understand why I was concerned WebOb was broken (and IMHO the ordering is wrong, but nobody but Apache implements it, and Apache implements it the same way as WebOb...) see this long issue: Pylons/webob#239 Either way, this is ready to be merged if you are happy with it. |
|
This looks great. Could you please add a changelog that mentions any possible incompatibilities? |
|
Should be no incompatibilities. It now does the right thing when the client provides an I can add a CHANGELOG announcing the change. |
|
I did match the signature for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to bring Pyramid in-line with the changes that were made to WebOb's exceptions and to allow for generation of JSON exceptions.
#2406