do not enforce default permissions on exception views #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this normalizes the behavior to work similar to require_csrf - if an explicit permission= is set on the view it will still be enforced, this just affects a default permission via config.set_default_permission - permission=NO_PERMISSION_REQUIRED was already forced on for notfound and forbidden views, this just helps out with other exception views
|
👍 |
mmerickel
added a commit
that referenced
this pull request
Apr 28, 2016
mmerickel
added a commit
that referenced
this pull request
May 1, 2016
stevepiercy
pushed a commit
to stevepiercy/pyramid
that referenced
this pull request
May 8, 2016
stevepiercy
pushed a commit
to stevepiercy/pyramid
that referenced
this pull request
May 8, 2016
This was referenced Sep 29, 2017
mmerickel
deleted the
fix/do-not-enforce-default-permissions-on-exception-views
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
permission=is set on the view it will still be enforced,this just affects a default permission via
config.set_default_permissionpermission=NO_PERMISSION_REQUIREDwas already forced on for notfoundand forbidden views, this just helps out with other exception views
This partially solves concerns with #2533