Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffolds: allow pytest run without args #2545

Closed
wants to merge 2 commits into from
Closed

Scaffolds: allow pytest run without args #2545

wants to merge 2 commits into from

Conversation

vincent-ferotin
Copy link
Contributor

Here is pull request related to this thread: https://groups.google.com/forum/#!topic/pylons-devel/AIqmefG6eIE ,
to allow usage of raw py.test command (without arguments) at newly created project's root by scaffolds.

Changes add two new files to scaffolds:

  • pytest.ini for pytest configuration, which set package as test path, scanning for all *.py files;
  • .coveragerc for coverage configuration, setting package to cover, and omitting tests files following test* pattern (for allowing py.test --cov invocation).

@mmerickel
Copy link
Member

I'm happy with this. I would have preferred to use setup.cfg since we use that for other things but since we don't use it anymore in the scaffolds this is an acceptable location and a bit more explicit for users to discover.

+1

@vincent-ferotin
Copy link
Contributor Author

Thanks!

@mmerickel
Copy link
Member

We need to rebase this on top of #2546 and update the docs accordingly. ping @stevepiercy It looks like you made that PR incompatible with these changes so can you help resolve them?

@stevepiercy
Copy link
Member

LGTM so far. We need to update any docs that use py.test and scaffolds, which includes off the top of my head, Quick Tour, Quick Tutorial, wiki, and wiki2. @mmerickel I'll take this on and backport from master to 1.7. Weekend plans got cancelled, so I have nothing better to do.

@vincent-ferotin have you signed contributors.txt? If not, please do so, commit, and push to your branch. That should automatically update this PR.

@stevepiercy
Copy link
Member

I created a new branch https://github.com/Pylons/pyramid/tree/vincent-ferotin-scaffolds-allow-pytest-run-without-args that replaces this PR, and gives me a place to push additional work on docs.

@vincent-ferotin please sign contributors.txt if you have not yet done so, and push the commit to that new branch. The PR #2550 will update automatically. Thank you!

@stevepiercy stevepiercy closed this May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants