-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support a [pserve] config section with a list of files to watch #2827
Conversation
bbb686b
to
361adfc
Compare
361adfc
to
3f13093
Compare
I'm thinking that I will update this to support asset specs such that if there's a
Currently everything is relative to the ini file and the I think ideally |
Well, I wouldn't support cwd-relativeness at all, usually it is just PITA because it is difficult to tell what the cwd happens to be at which time. I'd support full variable interpolations though, not only here. And how about globbing. I wouldn't want to change my development.ini all the time. Just pass the final "filename" into |
hmm though... |
Globbing is coming, I just need to think about it a bit more. It will be handled by hupper and so it won't require any changes to this PR aside from a doc improvement. Originally I wanted to support a glob that would actually watch for new files that matched... but it's somewhat sucky to implement so I might just re-evaluate the glob after each restart. |
well, if it is possible to register a new matcher, then someone could write a version that uses inotify say |
me thinks you haven't read anything about hupper |
Obviously no :D so perhaps just as simple as rewrite glob patterns into a regex for WatchdogFileMonitor à la fnmatch.translate (but better), trivial to support ** for recursive-glob on Python <3.5 too. Don't know how the polling should work, though |
b6220e1
to
d1d66cf
Compare
d1d66cf
to
9cab0e7
Compare
Okay I added support for some variable interpolation as well as asset specs. I'm looking at adding at least some basic glob support to hupper now. |
This is ready for review, I added some super basic globbing support to hupper by passing the patterns directly into |
Code looks good. Testing. |
LGTM and works! |
fixes #2732