When invoking an exception view, push the new threadlocals #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way when calling the threadlocal get_current_request() you get the same request object as the one that was passed to the view.
mmerickel
reviewed
May 30, 2017
pyramid/view.py
Outdated
| ) | ||
|
|
||
| try: | ||
| manager.push({'request': request, 'registry': registry}) |
There was a problem hiding this comment.
This push should go before the try. You do not want to try to pop if the push fails. It's pedantic but could avoid raising an exception from an exception.
There was a problem hiding this comment.
Gotcha. Will make the change.
digitalresistor
force-pushed
the
push_threadlocals_exception_view
branch
from
968c1a9
to
4f66355
Compare
mmerickel
added a commit
that referenced
this pull request
Jun 5, 2017
This was referenced Jun 20, 2017
This was referenced Jun 27, 2017
This was referenced Jul 10, 2017
This was referenced Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way when calling the threadlocal get_current_request() you get the
same request object as the one that was passed to the view.
Fixes the comment on: #3053 (comment)