Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol and port control #207

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Protocol and port control #207

merged 1 commit into from
Apr 6, 2023

Conversation

zupo
Copy link
Collaborator

@zupo zupo commented Apr 6, 2023

Continuation of #201.

Refs #176.

@zupo zupo mentioned this pull request Apr 6, 2023
@blueracer-io
Copy link

blueracer-io bot commented Apr 6, 2023

Unit tests performance report: ✅

Everything looks great, carry on!

Branch Number of tests Suite duration Mean test duration
main 86 1.7s1 18.6ms1
add/proto_port2 87 (1%) 1.5s (-14%) 16.9ms (-9%)

Found 1 new test, this is how it compares to existing tests:

Name Duration Percentile Score Status
test_views.test_add_explorer_view_custom_proto_port 16ms slower than 41% of existing tests

Footnotes

  1. The median/mean of the previous 13 runs. 2

  2. More specifically from commit 636981fa8a75f4b67fba90bf1e61e86c3ee08d1f in run #1.

@zupo zupo force-pushed the add/proto_port branch from b415824 to 98ffb69 Compare April 6, 2023 10:19
@zupo zupo merged commit 1c2fda3 into main Apr 6, 2023
@jschaeff
Copy link

jschaeff commented Apr 6, 2023

Thank you for integrating this little patch.

I realize it misses some documentation now.

Maybe we could add this in the README: https://github.com/Pylons/pyramid_openapi3#advanced-configuration 👍

### Specify protocol and port for getting the openapi3 spec file

Sometimes, it is neccessary to specify the protocol and port to access the openapi3 spec file. This can be configured in the `pyramid_openapi3_add_explorer` function, like for instance:

    config.pyramid_openapi3_add_explorer(route="/", proto_port=('https', 443))

@miketheman miketheman deleted the add/proto_port branch March 20, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants