Test validation of parameters in path, header and cookies #29
Conversation
zupo
changed the title
| @@ -181,3 +182,166 @@ def test_openapi_view_validate_HTTPExceptions() -> None: | |||
|
|
|||
| with pytest.raises(HTTPForbidden): | |||
| view(context, request) | |||
There was a problem hiding this comment.
Hey @gweis I need your eyes on this: there used to be a line like this here: assert str(exc.value) == "Unknown response http status: 403", but is was removed in later commits in #26.
Looking at the test_openapi_view_validate_HTTPExceptions test case, it seems that it is not testing anything? At least the comments say it's testing that un-spec-ed responses should be re-raised as InvalidResponse but there are not asserts to confirm this?
There was a problem hiding this comment.
Good catch. (totally overlooked that doc string).
The difference is, that the response is now validated inside the tween (not in the view wrapper).
So either this type of test should be done inside test_validation.py, where tests are run through a pyramid Router or this tests needs to be update. One way to do that would be like this: gweis@7dc65ca
There is one small issue with the tween. It only validates the response correctly if there is an exception view handler configured in the pyramid app. Usually this is the case per default, but the normal pyramid testing test setup does not install one. (I'll create another pull request to handle that case as well)
maybe this is what this comment referred to #26 (comment)
I took @gweis's commits and rebased them off of latest master: