Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.13 support using legacy-cgi #467

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Add Python 3.13 support using legacy-cgi #467

merged 2 commits into from
Oct 24, 2024

Conversation

luhn
Copy link
Contributor

@luhn luhn commented Oct 10, 2024 •
edited
Loading

A quick fix for #437 while #466 is in progress.

mmerickel
mmerickel reviewed Oct 10, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
mmerickel
mmerickel approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@mmerickel mmerickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to get this shipped in a bugfix release as 1.8.9 if we can just to unblock python 3.13.

@luhn
Copy link
Contributor Author

luhn commented Oct 10, 2024

Should I rebase to 1.8 branch?

@luhn
Copy link
Contributor Author

luhn commented Oct 10, 2024 •
edited
Loading

Looks like 1.8 branch didn't get 3.12 merged in, so we'd need to backport that as well. #459

@luhn luhn mentioned this pull request Oct 10, 2024
Merged
@sirosen sirosen mentioned this pull request Oct 22, 2024
Merged
digitalresistor
digitalresistor reviewed Oct 24, 2024
View reviewed changes
.github/workflows/ci-tests.yml Outdated
Comment on lines 42 to 46
# Linux and macOS don't have x86 python
- os: "ubuntu-latest"
architecture: x86
- os: "macos-latest"
architecture: x86
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's a vestige of #468. I'll rebase the branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's all good, there are no errors!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#467 (comment)

@digitalresistor
Copy link
Member

Line 44 in .github/workflows/ci-tests.yml needs to have the architecture removed:

webob/.github/workflows/ci-tests.yml

Line 44 in c3e3b5b

name: "Python: ${{ matrix.py }}-${{ matrix.architecture }} on ${{ matrix.os }}"

@digitalresistor
Copy link
Member

digitalresistor commented Oct 24, 2024 •
edited
Loading

Or... I am sorry, do we want to keep x86 architecture stuff in? In that case a rebase may be better. I guess the only platform that it matters on is Windows.

Feel free to rebase and nuke my commit to add x86 support back in.

@luhn
Copy link
Contributor Author

luhn commented Oct 24, 2024

x86 support is already nuked by way of #468, so it shouldn't be in this PR. I'm going to rebase to keep things tidy.

@luhn
Copy link
Contributor Author

luhn commented Oct 24, 2024

Done.

@digitalresistor digitalresistor merged commit e57a91c into Pylons:main Oct 24, 2024
25 checks passed
@digitalresistor
Copy link
Member

Thanks @luhn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digitalresistor digitalresistor digitalresistor left review comments

@mmerickel mmerickel mmerickel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luhn @digitalresistor @mmerickel