-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve dill incompatibility with attempt_import
.
#2419
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2419 +/- ##
==========================================
+ Coverage 84.41% 85.89% +1.48%
==========================================
Files 617 617
Lines 76183 76192 +9
==========================================
+ Hits 64309 65448 +1139
+ Misses 11874 10744 -1130
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@jsiirola - I'll look into resolving the failing tests. I know you're busy today. |
@mrmundt, I was just working in it. I think I just pushed a valid change that should fix the pickle issue. |
The failing tests are now all passing. I will merge the PR. |
Fixes #2414
Summary/Motivation:
Current
dill
implementations look for thedill
module by looking for the_dill
attribute on all objects in theglobals()
. This was causing missing modules (ModuleUnavailable
objects) to raise aDeferredImportError
. This adds a special case to that this behavior does not trigger theDeferredImportError
(and instead raises the "expected"AttributeError
.This also makes the
ModuleUnavailable
andDeferredImportModule
classes picklable.Changes proposed in this PR:
DeferredImportError
when attempting to retrieve a_dill
attributeModuleUnavailable
andDeferredImportModule
classes picklable.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: