v1.6.0 Fix most features. #56

gooin · 2023-10-02T03:27:07Z

Abasz · 2023-10-02T08:20:39Z

Is there a specific reason that you are still using the /proxy/ path on the connect api?

Actually, for some reasons I got errors on that and moved to connectapi.garmin.com without the /proxy/. I checked and I think this is used by Garth as well.

So for instance, activity list service: https://connectapi.garmin.com/activitylist-service/activities/search/activities
or download service: https://connectapi.garmin.com/download-service/files/activity/

gooin · 2023-10-02T08:30:09Z

Is there a specific reason that you are still using the /proxy/ path on the connect api?

Actually, for some reasons I got errors on that and moved to connectapi.garmin.com without the /proxy/. I checked and I think this is used by Garth as well.

So for instance, activity list service: https://connectapi.garmin.com/activitylist-service/activities/search/activities or download service: https://connectapi.garmin.com/download-service/files/activity/

I use UrlClass.ts not url.ts

Abasz · 2023-10-02T08:36:36Z

Is there a specific reason that you are still using the /proxy/ path on the connect api?
Actually, for some reasons I got errors on that and moved to connectapi.garmin.com without the /proxy/. I checked and I think this is used by Garth as well.
So for instance, activity list service: https://connectapi.garmin.com/activitylist-service/activities/search/activities or download service: https://connectapi.garmin.com/download-service/files/activity/

I use UrlClass.ts not url.ts

you are right... sorry I missed that.

gooin · 2023-10-02T08:38:58Z

Is there a specific reason that you are still using the /proxy/ path on the connect api?
Actually, for some reasons I got errors on that and moved to connectapi.garmin.com without the /proxy/. I checked and I think this is used by Garth as well.
So for instance, activity list service: https://connectapi.garmin.com/activitylist-service/activities/search/activities or download service: https://connectapi.garmin.com/download-service/files/activity/

I use UrlClass.ts not url.ts

you are right... sorry I missed that.

I Will delete it later.😂

gooin · 2023-10-02T15:06:30Z

Is there a specific reason that you are still using the /proxy/ path on the connect api?
Actually, for some reasons I got errors on that and moved to connectapi.garmin.com without the /proxy/. I checked and I think this is used by Garth as well.
So for instance, activity list service: https://connectapi.garmin.com/activitylist-service/activities/search/activities or download service: https://connectapi.garmin.com/download-service/files/activity/

I use UrlClass.ts not url.ts

you are right... sorry I missed that.

@Abasz removed...

kspetrov · 2023-10-03T13:07:13Z

@gooin Hi! What about workout methods? Or this is not in your plan?

gooin · 2023-10-03T13:08:50Z

Yes, I'm working on this. Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Kirill Petrov ***@***.***> Sent: Tuesday, October 3, 2023 9:07:24 PM To: Pythe1337N/garmin-connect ***@***.***> Cc: Yan Zhitao ***@***.***>; Mention ***@***.***> Subject: Re: [Pythe1337N/garmin-connect] v1.6.0 Fix most features. (PR #56) @gooin<https://github.com/gooin> Hi! What about workout methods? Or this is not in your plan? — Reply to this email directly, view it on GitHub<#56 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADJDEBL3WJ3S5L3STP7ABV3X5QEYZAVCNFSM6AAAAAA5O2JRO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBUHE2DGNZZHE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

kspetrov · 2023-10-03T13:12:20Z

Perfect! :) Thanks a lot!!!

gooin · 2023-10-03T15:27:56Z

Perfect! :) Thanks a lot!!!

Latest commit added workout methods. See 901a70f

pauly · 2023-10-09T19:49:56Z

Is the whole interface changing here? The original examples aren't working, neither is my code if I switch to this branch.
I see the change from

await GCClient.login(process.env.GUSER, process.env.GPASS)
const userProfile = await GCClient.getUserProfile()
const stepData = await GCClient.getSteps(new Date(date))

now there is no getSteps()

gooin · 2023-10-10T02:06:02Z

Is the whole interface changing here? The original examples aren't working, neither is my code if I switch to this branch. I see the change from
await GCClient.login(process.env.GUSER, process.env.GPASS)
const userProfile = await GCClient.getUserProfile()
const stepData = await GCClient.getSteps(new Date(date))
now there is no getSteps()

steps, sleep, weight, gear are not implemented yet, see GarminConnect.ts

Pythe1337N · 2023-10-19T08:32:04Z

examples/example.js

@@ -1,18 +1,33 @@
-const { GarminConnect } = require('garmin-connect');
+const { GarminConnect } = require('../dist/index');


This should still be 'garmin-connect'

Pythe1337N · 2023-10-19T08:32:42Z

package.json

@@ -1,12 +1,14 @@
 {
    "name": "garmin-connect",
-    "version": "1.5.0",
+    "version": "1.6.5",


Please do not bump version numbers, this will be done along with a new release

matin · 2023-10-26T15:51:42Z

@gooin well done! 👏🏽

gooin added 14 commits September 27, 2023 23:04

feat: Garmin signin with Oauth (initial version).

5d98de1

feat: handling errors

55203db

refactor: oauth1 & oauth2 exchange

a18ff73

feat: get user settings by api

34425d5

feat: http client common header

ebb3862

feat: export, import token & auto refresh token

30413da

feat: Activity API

964b89a

feat: upload and delete activity

85568eb

doc: update readme

efc98ce

feat: get OAUTH_CONSUMER from url, not hard code

8757b9a

feat: handle Account locked

439992f

feat: handle MFA (TODO)

c1bfccb

fix: missing ticket

a292f2f

feat: v1.6.0

354895a

gooin mentioned this pull request Oct 2, 2023

403 Forbidden Response #55

Closed

feat: make GarminConnect.client public

ce1e4ff

gooin closed this Oct 2, 2023

gooin reopened this Oct 2, 2023

gooin added 6 commits October 2, 2023 12:05

feat: exportToken

664660a

v1.6.1-rc.1

09f30fc

v1.6.1-rc.2

3a391c8

fix: refreshOauth2Token fetch OAUTH_CONSUMER

22c1d61

chore: remove logs

9560efa

v1.6.1

8cb3ed1

gooin mentioned this pull request Oct 2, 2023

"Update Phone Number" when signin matin/garth#19

Closed

new bug at sign in step: Handle Phone number

e82aa73

chore: remove unused codes

dd454dc

gooin added 3 commits October 3, 2023 13:32

fix: error handling

1d224c2

v1.6.2-rc.1

e96a6b9

fix: doc

68898c8

gooin added 2 commits October 3, 2023 23:24

feat: delete method

d9f1379

feat: workouts get add delete

901a70f

gooin added 5 commits October 9, 2023 17:22

feat: make old env happy

f6a8e18

v1.6.3

fbfc156

fix: make old env happy

d78bb98

fix: make old evn happy

5ecbe28

v1.6.5

8f17778

Pythe1337N requested changes Oct 19, 2023

View reviewed changes

Pythe1337N changed the base branch from master to gooin-fixes October 19, 2023 08:36

Pythe1337N merged commit baeed07 into Pythe1337N:gooin-fixes Oct 19, 2023

Pythe1337N mentioned this pull request Oct 19, 2023

added delete method for requests #54

Closed

app4g mentioned this pull request Oct 26, 2023

Gears Support (Link / Unlink) matin/garth#29

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v1.6.0 Fix most features. #56

v1.6.0 Fix most features. #56

gooin commented Oct 2, 2023 •

edited

Loading

Abasz commented Oct 2, 2023

gooin commented Oct 2, 2023

Abasz commented Oct 2, 2023

gooin commented Oct 2, 2023

gooin commented Oct 2, 2023

kspetrov commented Oct 3, 2023

gooin commented Oct 3, 2023 via email

kspetrov commented Oct 3, 2023

gooin commented Oct 3, 2023

pauly commented Oct 9, 2023

gooin commented Oct 10, 2023

Pythe1337N Oct 19, 2023

Pythe1337N Oct 19, 2023

matin commented Oct 26, 2023

		@@ -1,18 +1,33 @@
		const { GarminConnect } = require('garmin-connect');
		const { GarminConnect } = require('../dist/index');

v1.6.0 Fix most features. #56

v1.6.0 Fix most features. #56

Conversation

gooin commented Oct 2, 2023 • edited Loading

Abasz commented Oct 2, 2023

gooin commented Oct 2, 2023

Abasz commented Oct 2, 2023

gooin commented Oct 2, 2023

gooin commented Oct 2, 2023

kspetrov commented Oct 3, 2023

gooin commented Oct 3, 2023 via email

kspetrov commented Oct 3, 2023

gooin commented Oct 3, 2023

pauly commented Oct 9, 2023

gooin commented Oct 10, 2023

Pythe1337N Oct 19, 2023

Choose a reason for hiding this comment

Pythe1337N Oct 19, 2023

Choose a reason for hiding this comment

matin commented Oct 26, 2023

gooin commented Oct 2, 2023 •

edited

Loading