Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync multiple QDAC-IIs together #180

Merged
merged 15 commits into from
Dec 14, 2022
Merged

Sync multiple QDAC-IIs together #180

merged 15 commits into from
Dec 14, 2022

Conversation

jpsecher
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

Merging #180 (80df4cf) into main (ba7900b) will increase coverage by 1.84%.
The diff coverage is 97.08%.

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   19.38%   21.23%   +1.84%     
==========================================
  Files         126      130       +4     
  Lines       15701    16083     +382     
==========================================
+ Hits         3044     3415     +371     
- Misses      12657    12668      +11     
Impacted Files Coverage Δ
...contrib_drivers/tests/QDevil/test_sim_qdac2_awg.py 100.00% <ø> (ø)
...drivers/tests/QDevil/test_sim_qdac2_source_list.py 100.00% <ø> (ø)
...rivers/tests/QDevil/test_sim_qdac2_source_sweep.py 100.00% <ø> (ø)
...ib_drivers/tests/QDevil/test_sim_qdac2_triggers.py 100.00% <ø> (ø)
...ivers/tests/QDevil/test_sim_qdac2_virtual_gates.py 100.00% <ø> (ø)
...contrib_drivers/tests/QDevil/sim_qdac2_fixtures.py 78.12% <75.86%> (-1.88%) ⬇️
qcodes_contrib_drivers/drivers/QDevil/QDAC2.py 96.34% <92.20%> (-0.11%) ⬇️
...odes_contrib_drivers/drivers/QDevil/QDAC2_Array.py 98.57% <98.57%> (ø)
...rs/tests/QDevil/test_sim_qdac2_abstract_channel.py 100.00% <100.00%> (ø)
...drivers/tests/QDevil/test_sim_qdac2_arrangement.py 100.00% <100.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jpsecher
Copy link
Contributor Author

So I guess I am ready for release.

The driver for multiple QDACs does not yet behave as a proper Visa instrument, and I will work on an update later when I figure out the most compatible way to achieve that. But I think it is important that we have release now so that people can start using the synchronisation feature.

@astafan8
Copy link
Contributor

@jpsecher could you merge the latest greatest main into your branch? then the PR will merge itself

@astafan8 astafan8 merged commit a90416c into QCoDeS:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants