Add QDAC1 notebook from QCoDeS #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it is not executed during automatic tests Removed unused imports from drivers Replaced parameter .get_latest by .cache and ._save_val by .cache.set
Apply most changes suggested in review, and changed behavior to not touch the outputs at initialisation. The QDAC state is instead read at initialisation leaving any on going ramping to continue, thus restoring the internal generator book keeping. A reset command is added to make it possible to reset all parameters to default values.
2 tasks
Codecov Report
@@ Coverage Diff @@
## main #198 +/- ##
=======================================
Coverage 20.64% 20.64%
=======================================
Files 131 131
Lines 16540 16540
=======================================
Hits 3415 3415
Misses 13125 13125 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bors bot
added a commit
to microsoft/Qcodes
that referenced
this pull request
Jan 23, 2023
4905: Add types to shared test modules r=jenshnielsen a=jenshnielsen Mainly to the fixtures and so on with the aim of making the tests easier to understand 4932: Deprecate QDevil QDAC 1 driver r=jenshnielsen a=jenshnielsen The driver has been moved to qcodes_contrib_drivers (0.18.0) TODO - [x] Changelog - [x] Add the notebook to qcodes_contrib_drivers QCoDeS/Qcodes_contrib_drivers#198 Co-authored-by: Jens H. Nielsen <jenshnielsen@gmail.com> Co-authored-by: Jens H. Nielsen <Jens.Nielsen@microsoft.com>
astafan8
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.