Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thorlab drivers for KDC101, TDC001, PM100D; extend Kinesis libraries to be more general and support more drivers #244

Merged
merged 34 commits into from
Aug 31, 2023

Conversation

julienbarrier
Copy link
Contributor

  • Add drivers for:
    • KDC101
    • TDC001
    • PM100D
  • refactor the Kinesis libraries to include a large range of drivers + potentially new types of devices
  • place APT modules and Kinesis into a private subfolder (in the model of the Rohde&Schwartz drivers)

Tested with KDC101, TDC001, PM100D.
The KLS1550 driver was edited to allow a more general Kinesis library, but could not be tested with a real device.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Merging #244 (8d8a367) into main (04bd685) will decrease coverage by 0.58%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   19.86%   19.29%   -0.58%     
==========================================
  Files         139      145       +6     
  Lines       17459    17980     +521     
==========================================
  Hits         3469     3469              
- Misses      13990    14511     +521     
Files Changed Coverage Δ
qcodes_contrib_drivers/drivers/Thorlabs/K10CR1.py 0.00% <0.00%> (ø)
qcodes_contrib_drivers/drivers/Thorlabs/KDC101.py 0.00% <0.00%> (ø)
qcodes_contrib_drivers/drivers/Thorlabs/KLS1550.py 0.00% <0.00%> (ø)
qcodes_contrib_drivers/drivers/Thorlabs/MFF10x.py 0.00% <0.00%> (ø)
qcodes_contrib_drivers/drivers/Thorlabs/PM100D.py 0.00% <0.00%> (ø)
qcodes_contrib_drivers/drivers/Thorlabs/PRM1Z8.py 0.00% <0.00%> (ø)
qcodes_contrib_drivers/drivers/Thorlabs/TDC001.py 0.00% <0.00%> (ø)
...es_contrib_drivers/drivers/Thorlabs/private/APT.py 0.00% <0.00%> (ø)
...des_contrib_drivers/drivers/Thorlabs/private/CC.py 0.00% <0.00%> (ø)
...des_contrib_drivers/drivers/Thorlabs/private/LS.py 0.00% <0.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

qcodes_contrib_drivers/drivers/Thorlabs/KDC101.py Outdated Show resolved Hide resolved
qcodes_contrib_drivers/drivers/Thorlabs/KDC101.py Outdated Show resolved Hide resolved
qcodes_contrib_drivers/drivers/Thorlabs/KLS1550.py Outdated Show resolved Hide resolved
qcodes_contrib_drivers/drivers/Thorlabs/PM100D.py Outdated Show resolved Hide resolved
qcodes_contrib_drivers/drivers/Thorlabs/PM100D.py Outdated Show resolved Hide resolved
qcodes_contrib_drivers/drivers/Thorlabs/PM100D.py Outdated Show resolved Hide resolved
@astafan8 astafan8 changed the title Add Thorlab drivers Add Thorlab drivers for KDC101, TDC001, PM100D Aug 31, 2023
@astafan8 astafan8 changed the title Add Thorlab drivers for KDC101, TDC001, PM100D Add Thorlab drivers for KDC101, TDC001, PM100D; extend Kinesis libraries to be more general and support more drivers Aug 31, 2023
@astafan8 astafan8 merged commit 602b8b2 into QCoDeS:main Aug 31, 2023
8 checks passed
@julienbarrier julienbarrier deleted the thorlab_drivers branch August 31, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants