Keithley 6430: Add appropriate lower limit for voltage compliance #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing an SCPI command to set a voltage compliance value that is below the minimum accepted by the device (0.2 mV) will cause the value to be silently ignored, and the previous compliance level will stay. Without this modification, it is possible to set the compliance to 0.1 mV but accidentally pass 20 V, since that is the default voltage compliance when the device is booted.
mgunyho
temporarily deployed
to
testing-environment
GitHub Actions
Inactive
mgunyho
temporarily deployed
to
testing-environment
GitHub Actions
Inactive
mgunyho
temporarily deployed
to
testing-environment
GitHub Actions
Inactive
mgunyho
temporarily deployed
to
testing-environment
GitHub Actions
Inactive
mgunyho
temporarily deployed
to
testing-environment
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
=======================================
Coverage 11.49% 11.49%
=======================================
Files 123 123
Lines 16745 16745
=======================================
Hits 1925 1925
Misses 14820 14820 ☔ View full report in Codecov by Sentry. |
|
Thanks @mgunyho |
jenshnielsen
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We noticed a bug in this SMU driver: writing an SCPI command to set a voltage compliance value that is below the minimum accepted by the device (0.2 mV) will cause the value to be silently ignored, and the previous compliance level will stay. Without this modification, it is possible to set the compliance to 0.1 mV in QCoDeS but accidentally pass 20 V, since that is the default voltage compliance when the device is booted. This PR fixes this behavior.