Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax versioningit build dependency #39

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Relax versioningit build dependency #39

merged 1 commit into from
Aug 28, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 26, 2023

Now that versioningit 2.2.0 is released, would it be possible to relax the dependency so that we can build using it? I don't see anything scary in the release notes.

I have also removed wheel, per setuptools documentation:

Historically this documentation has unnecessarily listed wheel in the requires list, and many projects still do that. This is not recommended. The backend automatically adds wheel dependency when it is required, and listing it explicitly causes it to be unnecessarily required for source distribution builds. You should only include wheel in requires if you need to explicitly access it during build time (e.g. if your project needs a setup.py script that imports wheel).

@jenshnielsen
Copy link
Contributor

An unrelated test has started failing #41

@jenshnielsen jenshnielsen merged commit d28c48c into QCoDeS:main Aug 28, 2023
10 checks passed
@tjni tjni deleted the versioningit branch August 28, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants