Replace HTML hyperlinks with Markdown image hyperlinks in ipynb docs #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
|
I made the changes using |
|
This is perfect– thanks for contributing, @bterrific2008! Don't worry about the tests, that's on our end, and will be fixed within a couple days. And the ipynb version number change is fine, no worries there. |
jxmorris12
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue where the 'Run in Colab' buttons not rendered on readthedocs #244.
The cause of this issue is that nbsphinx does not currently support HTML-style hyperlinks.
This pull request changes the HTML-style hyperlinks used for the 'Run in Colab' and 'View Source in GitHub' buttons with Markdown image links. Screenshots of what that looks like are attached below.
The docs build correctly after running
make html. I didn't run any of the other tests, as this change just affects thedocs/folder.I think I got all of the ipynb files in
docs/. LetScreenshot of how it looks on jupyter notebook:
Screenshot of how it looks from the browser: