Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic integration tests for CUDA code: add reference data or disable? #1729

Closed
prckent opened this issue Jul 15, 2019 · 4 comments
Closed
Assignees
Labels

Comments

@prckent
Copy link
Contributor

prckent commented Jul 15, 2019

Currently the deterministic tests are run for the legacy CUDA code. Necessarily they will always fail due to the different numerics. i.e. We rely on the statistical integration tests for correctness and to detect meaningful change.

It would be helpful to (1) have the deterministic tests always work ("ctest -L deterministic") and (2) catch changes on Volta, which I think is a safe reference for now. Do we add reference data or disable the numerical checks for now?

@jtkrogel
Copy link
Contributor

I vote for adding data for at least a subset of the deterministic tests.

@ye-luo
Copy link
Contributor

ye-luo commented Jul 15, 2019

Let us do disabling first. It is basically adding if-else which will be anyway needed for adding a separate set for CUDA.

@Hyeondeok-Shin
Copy link
Contributor

I'm going to work with separated deterministic test for CUDA code as @jtkrogel mentioned. As a first step, I'll disable the deterministic test for CUDA with the current reference now as @ye-luo comment in order to avoid confusion.

@ye-luo
Copy link
Contributor

ye-luo commented Feb 3, 2023

Legacy CUDA has been removed from the code base #4431

@ye-luo ye-luo closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants