Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Legacy CUDA and disable QMC_CUDA build option #4431

Merged
merged 13 commits into from
Feb 1, 2023

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Feb 1, 2023

Proposed changes

A good day. I have not touched tests folder, need to decide how to clean up/repurpose if there is any need.

What type(s) of changes does this code introduce?

  • Other (please describe):

Does this introduce a breaking change?

  • Yes, legacy CUDA is gone

What systems has this change been tested on?

epyc-server

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@ye-luo
Copy link
Contributor Author

ye-luo commented Feb 1, 2023

Test this please

@ye-luo
Copy link
Contributor Author

ye-luo commented Feb 1, 2023

Test this please

@ye-luo
Copy link
Contributor Author

ye-luo commented Feb 1, 2023

Test this please

@prckent prckent changed the title Remove legacy cuda Remove Legacy CUDA and disable QMC_CUDA build option Feb 1, 2023
@prckent prckent self-requested a review February 1, 2023 18:51
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on available energy there are additional files and directories to cleanup or decide to tackle in a later PR:

  • README.md
  • docs/*.rst
  • config/*.sh
  • CMake/*.cmake

I changed the title to be more obvious to non-specialists.

@prckent
Copy link
Contributor

prckent commented Feb 1, 2023

I have updated the branch protection rules so that results from legacy CUDA builds are not required to pass.

@prckent
Copy link
Contributor

prckent commented Feb 1, 2023

Note that I don't know what, say, "ornl-nitrogen CI GCC9-MPI-CUDA-AFQMC-Complex " actually is. It passes so it can't be using legacy CUDA and it is also definitely not an offload build if it is using GCC9. The name needs updating. (@williamfgc ?)

@ye-luo
Copy link
Contributor Author

ye-luo commented Feb 1, 2023

Note that I don't know what, say, "ornl-nitrogen CI GCC9-MPI-CUDA-AFQMC-Complex " actually is. It passes so it can't be using legacy CUDA and it is also definitely not an offload build if it is using GCC9. The name needs updating. (@williamfgc ?)

This is ENABLE_CUDA+BUILD_AFQMC without offload.

@ye-luo
Copy link
Contributor Author

ye-luo commented Feb 1, 2023

Depending on available energy there are additional files and directories to cleanup or decide to tackle in a later PR:

* README.md

* docs/*.rst

* config/*.sh

* CMake/*.cmake

Added #4432

@williamfgc
Copy link
Contributor

Yes, Legacy-CUDA jobs are marked explicitly anticipating this PR. After this gets merged I will reorganize CI scripts to separate ornl from GitHub Actions runners workflows.

@prckent prckent self-requested a review February 1, 2023 19:40
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ye for this 40K source line removal!

I'll note that this PR is fully consistent with the advertised planned removal of the limited feature legacy CUDA support in the 3.16.0 release notes. Users needing NVIDIA GPU support should switch to the offload build with CUDA optimizations, i.e. ENABLE_OFFLOAD=ON, ENABLE_CUDA=ON. This version and the associated batched drivers support more features and is already being used for production science.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants