-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle h5 group check in hdf_archive #4547
Comments
The comment is asking for the error to be handled in the call to To be clear, the desired behavior is: |
I don't feel right returning hid_t type outside hdf_archive which should hid details of the hdf5 library.
|
Addresses issue QMCPACK#4547 (handle h5 group check in hdf_archive) When 'push' is called with the createit flag set to false, and the group does not exist, throw an exception. Also throw an exception if the file is not open. Remove the return value (use 'top' to get the value if it's really needed) Store the hdf archive filename so it can be included in the error message in the exception.
Is your feature request related to a problem? Please describe.
See comment
https://github.com/QMCPACK/qmcpack/pull/4541/files#r1158964516
The text was updated successfully, but these errors were encountered: