Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QMCPACK build instructions for ARM #1148

Merged
merged 4 commits into from
Nov 7, 2018
Merged

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Nov 6, 2018

I only need to build hdf5 and newer cmake beyond the script shows.
In the script, I treat armclang as clang to workaround cmake.
Message was sent to arm to improve the cmake compatibility.
C++14 is fine.

@ghost ghost assigned ye-luo Nov 6, 2018
@ghost ghost added the in progress label Nov 6, 2018
@prckent prckent self-requested a review November 6, 2018 20:02
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

  1. A manual entry is needed for visibility and additional explanations.
  2. I would prefer this is a manual entry only. It is a non-production system that our cmake handles fine. (e.g. We don't have build scripts for x86 and only have them for a few important systems.).
  3. Please also cite + link to the existing ARM page on QMCPACK.

@ye-luo
Copy link
Contributor Author

ye-luo commented Nov 6, 2018

Good point. A manual entry is better. I will move it to the manual and keep it there only.
3. I don't like some hacks on the ARM page. I will ask them to align with us.

@ye-luo
Copy link
Contributor Author

ye-luo commented Nov 6, 2018

I moved the recipe to manual. But I'm hesitating to cite the link in our manual. First, they should follow us not the opposite. We are the official one. Second, links may easily get changed.

@ghost ghost assigned prckent Nov 7, 2018
@prckent
Copy link
Contributor

prckent commented Nov 7, 2018

(I could find two sources of build instructions https://developer.arm.com/products/software-development-tools/hpc/resources/porting-and-tuning/building-qmcpack-with-arm-compiler and https://gitlab.com/arm-hpc/packages/wikis/packages/qmcpack . The second is user contributed and might be the original source. We could PR updated instructions to this wiki e.g. when v3.6.0 is out.)

@prckent prckent changed the title Configuration script for armclang QMCPACK build instructions for ARM Nov 7, 2018
@prckent prckent merged commit c9524a6 into QMCPACK:develop Nov 7, 2018
@ghost ghost removed the in progress label Nov 7, 2018
@ye-luo
Copy link
Contributor Author

ye-luo commented Nov 7, 2018

@prckent. Correct, I got email from ARM that we can update the gitlab and then they will update the webpage accordingly.

@ye-luo ye-luo deleted the recipe-armclang branch November 16, 2018 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants