-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nexus PySCF interface #1220
Nexus PySCF interface #1220
Conversation
Can one of the maintainers verify this patch? |
1 similar comment
Can one of the maintainers verify this patch? |
Ready for review. |
okay to test |
Are examples and/or tests coming? One of the problems with Nexus is discoverability. It has a huge number of features and it's hard to find out what they are. Nexus doesn't document the features of the code it drives (nor should it - that's far too involved), so one has to read the documentation for the target code, and then figure out how to get Nexus to generate that feature. |
I completely agree. The best I can do is provide examples, which are coming (if slowly) and go through things in more detail during the monthly calls. This is going in now because it enables science Anouar and I are pursuing immediately. |
Below is an example if you want to try it out (based on the h2o example included in PySCF): |
|
Contents of 01-h2o.py (the template):
|
PySCF is distributed under Apache 2.0 license, is this compatible with ours? |
Do you want to include PySCF examples in nexus? Or something else - what do you want to do that involves license policy? |
Why the license concern? We shouldn't be copying any files from PySCF to have a clean situation. Any examples similar to those in PySCF should be cleanly rewritten. |
PySCF has a very large number of examples. Demonstrating how to do some of these with Nexus would be ideal--not copying but basing new files (e.g. the templates) off of them, with any attribution as required. A situation like this, AFAIK, is a good example of why codes are released as open source. Apache considers UIUC to be similar to its own license: http://www.apache.org/legal/resolved.html#category-a. There does not appear to be a large risk so long as the requirements are observed. Is there one I am missing? Apart from risk, I can understand not wanting to do the added work of meeting the requirements. I'm quite open to everyone's advice on this. |
Is there anything in this PR from PySCF covered by their license? Yes or No? I need a clear answer before we can merge. As for adding examples of using other codes, I prefer that we only add files covered by our license. We already do this for other codes. |
There is nothing in this PR covered by their license. The example in the comments above (01-h2o.py, not included anywhere in mergable files) was derived from one of their files. |
If this point is sticky on its own, I can delete the comment. |
Anything else needed here? |
Thanks Jaron. Just wanted to be sure. |
This PR contains a Nexus interface to PySCF. The idea is to be able to drive arbitrary PySCF scripts (based on template files), with the possibility for follow-on QMCPACK calculations.
Generation of Mole/Cell input and the additional conversion step via savetoqmcpack are automated.
Anticipate completion in a day or so.
Tasks: