Nexus: update for Cori #1463
Merged
Nexus: update for Cori #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Can one of the maintainers verify this patch? |
|
Okay to test |
ye-luo
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains modifications to handle the dual nature of Cori. Cori contains both Haswell and KNL nodes which effectively comprises two different machines from the point of view of job submission.
The updates allow the Cori supercomputer class to update its internal state relating to Haswell/KNL node anatomy when processing the job inputs prior to creating job submission scripts. I could have instead created two classes, e.g. CoriHaswell and CoriKNL, but this would preclude submission to both partitions from within the same Nexus script as is possible with the current modifications.