-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nexus: add PySCF examples #1552
Conversation
Can one of the maintainers verify this patch? |
okay to test |
@anbenali Any comments on the second point? Is this a reasonable change? |
To address point 2, give me 1 or 2 more hours t and finalize the new API
for solids as the complex evaluation is almost complete. In the PR in
progress your point is addressed I believe but I am still finalizing a few
details.
For the water energy that is weird.. can you give more details?
…On Tue, Apr 23, 2019, 13:19 jtkrogel ***@***.***> wrote:
@anbenali <https://github.com/anbenali> Any comments on the second point?
Is this a reasonable change?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1552 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AF4XVQYP23HRZ7ZYYZBBV53PR5HKZANCNFSM4HG4UTVA>
.
|
For point 2, all that is needed is that the files made by convert4qmc have the same names whether you are running a molecule or a solid. For the water case (point 1), this is what I get with PySCF:
And this is what I get with QMCPACK:
The files are attached. See scf.py, c4q.in, and vmc.in.xml. Hopefully it is a novice mistake on my part. |
@anbenali I see it now. Pyscf is changing the atomic coordinates (presumably because symmetries are on?) This is the input structure (angstrom):
This is what comes out of convert4qmc:
|
Point 2 has been address in PR #1560. Point 1 is strange... Let me look at it.. yes symmetries are on but this is strange to move the Oxygen atom coordinates... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for #1578 to me merged to accept this merge.
Please go ahead and merge this one in. I can check for compatibility and post a brief update if needed. |
In this PR, examples are added for PySCF and PySCF to QMCPACK workflows for both molecular and solid state cases (water molecule and diamond).
There are two issues that remain before this PR can be merged.
Once confirmed by @anbenali, separate GitHub issues + resolution can be made for these points.