Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement flag for test verbosity during cmake configuration #1724

Merged
merged 4 commits into from
Jul 15, 2019
Merged

Implement flag for test verbosity during cmake configuration #1724

merged 4 commits into from
Jul 15, 2019

Conversation

prckent
Copy link
Contributor

@prckent prckent commented Jul 13, 2019

Add new cmake flag QMC_VERBOSE_TEST_CONFIGURATION and update messaging throughout cmake configuration to reduce output when QMC_VERBOSE_TEST_CONFIGURATION=0 (default).

I will update the documentation after initial review.

Closes #1224

@prckent
Copy link
Contributor Author

prckent commented Jul 15, 2019

Updated. Changed the flag to QMC_VERBOSE_CONFIGURATION since there will likely be other uses. Updated the docs.

@markdewing
Copy link
Contributor

An alternate implementation would be to create a function TEST_CONFIG_MESSAGE to replace the existing calls to MESSAGE and put the if test for QMC_VERBOSE_CONFIGURATION inside that function.
The alternate implementation has the advantage to putting the test in single place. It has the disadvantage of adding an extra function (and layer of indirection).
The solution in this PR has the advantage of being more direct and obvious, and the disadvantage is it requires adding the if-test everywhere it is needed.

@prckent
Copy link
Contributor Author

prckent commented Jul 15, 2019

I thought about implementing a function at the time but went the simple route. Over time the trend should be to less of these as we move towards one build that does everything. I noticed that the cmake code around the tests is duplicated in several places so there are other efficiencies to gain.

We might need to add some more messages so that cmake looks like it is making enough progress.

@ye-luo
Copy link
Contributor

ye-luo commented Jul 15, 2019

We will add more tests and I feel the current scheme is inferior to a function MESSAGE_VERBOSE.
If we need to rename the option or move something from MESSAGE to MESSAGE_VERBOSE, a function is much simpler. Let us get it right now.

@prckent
Copy link
Contributor Author

prckent commented Jul 15, 2019

Done.

I moved the include of macros.cmake to the topmost CMakeLists.txt to have visibility of MESSAGE_VERBOSE and reduced our overzealous reinclusion of that file throughout.

@prckent prckent added this to the v3.8.0 Release milestone Jul 15, 2019
@markdewing markdewing merged commit 7f498e5 into QMCPACK:develop Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce output about testing during cmake configuration
3 participants