-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mpi walker transmission fix #2232
Merged
ye-luo
merged 13 commits into
QMCPACK:develop
from
PDoakORNL:mpi_walker_transmission_fix
Jan 24, 2020
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1647b7a
cleaner particleset loadwalker call for crowd
PDoakORNL c00e0bd
fixes from Deiverged Debugging branch
PDoakORNL 884fcab
unit tests passing
PDoakORNL d57aa8b
this is really an essential unit test.
PDoakORNL a27dbda
update MCPopulation constructor in legacy cuda test.
PDoakORNL d2f9854
truncation of received message hang fixed.
PDoakORNL 9dc8ac9
better trial energies now issue after 15 steps.
PDoakORNL 91706a5
dropping useless debug cout
PDoakORNL abcf842
Merge branch 'develop' into mpi_walker_transmission_fix
PDoakORNL 759c925
return of classic openmp threading for Ham mw_eval
PDoakORNL 7e0626f
Merge branch 'mpi_walker_transmission_fix' of github.com:PDoakORNL/qm…
PDoakORNL 6684eba
Reduce GNU warnings.
ye-luo bd81108
Merge remote-tracking branch 'github/develop' into mpi_walker_transmi…
ye-luo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,15 +41,8 @@ void Crowd::addWalker(MCPWalker& walker, ParticleSet& elecs, TrialWaveFunction& | |
|
||
void Crowd::loadWalkers() | ||
{ | ||
auto it_walker = mcp_walkers_.begin(); | ||
auto it_walker_elecs = walker_elecs_.begin(); | ||
//flex walkers here | ||
while (it_walker != mcp_walkers_.end()) | ||
{ | ||
(*it_walker_elecs).get().loadWalker(*it_walker, true); | ||
++it_walker; | ||
++it_walker_elecs; | ||
} | ||
for(int i = 0; i < mcp_walkers_.size(); ++i) | ||
walker_elecs_[i].get().loadWalker(mcp_walkers_[i], true); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Like this much better than iterators. |
||
} | ||
|
||
void Crowd::setRNGForHamiltonian(RandomGenerator_t& rng) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this causing problems in debug build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it appears that the first -fomit -fno-omit wins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMAKE_XXX_FLAGS is added to all builds.
For a build release CMake invokes both
$CMAKE_XXX_FLAGS $CMAKE_XXX_FLAGS_RELEASE
. If all the builds are intended, add to CMAKE_XXX_FLAGS. If release builds are intended, add to CMAKE_XXX_FLAGS_RELEASEThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean the CMAKE_C(XX)_FLAGS should not contain
-f-omit-frame-pointer
if you don't want that in the flags for the debug build. This fixes that. While leaving this optimization in the default RelWithDebugInfo and Release.