Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #2413 #2435

Merged
merged 5 commits into from
May 7, 2020
Merged

fix for #2413 #2435

merged 5 commits into from
May 7, 2020

Conversation

PDoakORNL
Copy link
Contributor

Proposed changes

Increased default WALKER_MAX_PROPERTIES in cmake.
ConstantSizeMatrix now returns more useful error messages when its size limits are exceeded.

close #2413

What type(s) of changes does this code introduce?

  • Bugfix
  • Build related changes

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

leconte

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes This PR is up to date with current the current state of 'develop'

  • Yes Code added or changed in the PR has been clang-formatted

  • No. This is an runtime issue caused by building the code with a reduced WALKER_MAX_PROPERTIES and then having an skestimator due to a high kvector count attempt to add excess walker properties. There are already plans to change the serialization of Walkers and their elements. These should return ownership and serialization responsibility for these "Properties" to the estimator.

  • No. Documentation has been added (if appropriate)

@ye-luo ye-luo merged commit e64a4fb into QMCPACK:develop May 7, 2020
Paul-St-Young added a commit to Paul-St-Young/qmcpack that referenced this pull request Aug 11, 2020
increase WALKER_MAX_PROPERTIES to 2048
@PDoakORNL PDoakORNL deleted the fix_2413 branch February 23, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constant size matrix errors for estimator properties
2 participants