fix for #2413 #2435
Merged
fix for #2413 #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ye-luo
approved these changes
May 7, 2020
Paul-St-Young
added a commit
to Paul-St-Young/qmcpack
that referenced
this pull request
Aug 11, 2020
increase WALKER_MAX_PROPERTIES to 2048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Increased default WALKER_MAX_PROPERTIES in cmake.
ConstantSizeMatrix now returns more useful error messages when its size limits are exceeded.
close #2413
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
leconte
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.
Yes This PR is up to date with current the current state of 'develop'
Yes Code added or changed in the PR has been clang-formatted
No. This is an runtime issue caused by building the code with a reduced WALKER_MAX_PROPERTIES and then having an skestimator due to a high kvector count attempt to add excess walker properties. There are already plans to change the serialization of Walkers and their elements. These should return ownership and serialization responsibility for these "Properties" to the estimator.
No. Documentation has been added (if appropriate)