Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus: fix type check for reblock_factors in qmc-fit #2830

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

jtkrogel
Copy link
Contributor

@jtkrogel jtkrogel commented Dec 29, 2020

Proposed changes

Expand integer type check of reblock_factors input to qmc-fit to include numpy integer types. This enables correct application of a single user provided reblocking factor to each timestep data series.

This issue was reported by Gopal Iyer.

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Laptop

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@qmc-robot
Copy link

Can one of the admins verify this patch?

@prckent
Copy link
Contributor

prckent commented Dec 29, 2020

OK to test

@ye-luo ye-luo merged commit 1b2a8ca into QMCPACK:develop Dec 29, 2020
@jtkrogel jtkrogel deleted the nx_fix_qfit_rbtype branch March 22, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants