-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ${Python3_EXECUTABLE} instead of shebang on top of Python files #3745
Conversation
There are a lot of utilities and examples touched here that are not run by CMake. Many of the same considerations as for Nexus apply. However there is an argument for requiring the "correct" python to have to be specified by the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
examples, labs and utils need to keep the shebang as they are not invoked by CMake/CTest.
Keeping all the shebangs would be a reasonable (and safe) option. Removing them all seems like a temporary hack to find all places python scripts are called from cmake to address #3680. |
I think keeping she-bangs in anything a user might invoke is desirable. If the default provided by the she-bang is somehow wrong for their environment, they can always invoke |
1463822
to
a27f6a6
Compare
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
b1598fa
to
4b8fde5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List of modified files LGTM
Test this please |
Please review the developer documentation
on the wiki of this project that contains help and requirements.
Proposed changes
Describe what this PR changes and why. If it closes an issue, link to it here
with a supported keyword.
This removes the shebang on top of Python files. CMake was updated to use ${Python3_EXECUTABLE}.
I avoided files in the nexus sub-directory.
Fixes #3680
What type(s) of changes does this code introduce?
Delete the items that do not apply
Does this introduce a breaking change?
What systems has this change been tested on?
Checklist
Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.