Nexus: update VASP keywords to version 6.3 #4056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ye-luo
previously approved these changes
Jun 9, 2022
|
Does this successfully read/parse all the tests shipped with v6.3? |
|
Good question. I've not checked. If you provide a link/access to the files, I will test it. |
|
Test this please |
|
Please place a hold on this. More updates are coming to address Paul's comment. |
Put it as draft. Please remove draft once it is ready. |
|
Updates now complete to read/write all keywords from all INCARS the VASP 6.3 test set. |
|
Test this please |
ye-luo
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update internal keyword specification in Nexus to VASP 6.3
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Laptop
Checklist