Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UHF/UKS support in Pyscf converter #4089

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Add UHF/UKS support in Pyscf converter #4089

merged 1 commit into from
Jul 1, 2022

Conversation

aannabe
Copy link
Contributor

@aannabe aannabe commented Jul 1, 2022

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Fixes #3958
I tested the changes on the F atom and the SCF vs VMC/NoJ energies agree for UHF:

SCF: -23.942446 Ha
VMC: -23.9427(2) Ha

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

OLCF/Andes

Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gani

@ye-luo ye-luo changed the title Fix for UHF/UKS Pyscf converter Add UHF/UKS support in Pyscf converter Jul 1, 2022
@ye-luo
Copy link
Contributor

ye-luo commented Jul 1, 2022

Test this please

@ye-luo ye-luo enabled auto-merge July 1, 2022 14:31
@ye-luo ye-luo merged commit 9ca5c94 into QMCPACK:develop Jul 1, 2022
@aannabe aannabe deleted the fix_pyscf_converter branch July 1, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

savetoqmcpack is not working for unresticted HF of KS in Pyscf
3 participants