-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nexus: fix convert4qmc hdf5 issue #4243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please put a comment about why this is done?
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Where does .orbs.h5 get used? Is it possible to propagate the name of the h5 file where it is needed, rather than make symbolic link? |
It looks like there are cases in convert4qmc that can still produce an |
Yes, it would try and fail to make a symlink in those cases but proceed fine anyway. I can put in a file existence check before proceeding with the attempted symlink creation. |
More safety checks added. Now the symlink will only be made if an h5 file has been provided and one has not been created by convert4qmc. |
Test this please |
Proposed changes
Fix an issue with expected filenames.
convert4qmc
no longer produces an hdf5 file when given one from PySCF. This leads to incorrect paths being provided to QMCPACK for the orbitals. Fix this by inserting a symlink in place of the file convert4qmc used to generate.What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Laptop
Checklist