Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand distance table unit tests to cover more BC. #4374

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Dec 20, 2022

Proposed changes

More unit tests.

What type(s) of changes does this code introduce?

  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc-server

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted
  • Yes. This PR adds tests to cover any new code, or to catch a bug that is being fixed

@ye-luo
Copy link
Contributor Author

ye-luo commented Dec 20, 2022

Test this please

Copy link
Contributor

@PDoakORNL PDoakORNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to get more unit tests.

@PDoakORNL PDoakORNL merged commit 45ce507 into QMCPACK:develop Dec 20, 2022
@ye-luo ye-luo deleted the expand-dist-table-tests branch December 20, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants