-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ENABLE_PPCONVERT option and skip ppconvert compilation when cross compiling. #4601
Conversation
Test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QMC_ISNAN -> QMC_ENABLE_ISNAN or QMC_USE_ISNAN
I think either of the above would be clearer.
Add to docs.
A second thought on the name of the cmake option. QMC_USE_ISNAN is reserved for a global option. Here, there is special customization for ppconvert and thus introduce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test this please |
Test this please |
Proposed changes
CrayLinuxEnvironment is considered cross-compiling. Thus try_run requires user input and stop.
Consider ppconvert is not critical, simply turn it off by default.
QMC_ISNAN option can be used to override the detection.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Frontier/Crusher
Checklist