Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine EinsplineSetBuilder::ReadOrbitalInfo error handling. #4746

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Sep 26, 2023

Proposed changes

Addresses #4744 (comment)
the refined error for #4744 reproducer is

ERROR HDF5 read failure in hdf_archive::read /format
EinsplineSetBuilder::ReadOrbitalInfo h5 file format is too old or it is not a bspline orbital file!
EinsplineSetBuilder::set_metadata Error reading orbital info from HDF5 file.

What type(s) of changes does this code introduce?

  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

laptop

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@ye-luo
Copy link
Contributor Author

ye-luo commented Sep 26, 2023

Test this please

markdewing
markdewing previously approved these changes Sep 26, 2023
@prckent
Copy link
Contributor

prckent commented Sep 26, 2023

I added a test of this feature. Can someone comment that they are OK with the test and refine if not?

1693:   Reading 4 orbitals from HDF5 file.
1693: ERROR HDF5 read failure in hdf_archive::read /format
1693: EinsplineSetBuilder::ReadOrbitalInfo h5 file format is too old or it is not a bspline orbital file!
1693: EinsplineSetBuilder::set_metadata Error reading orbital info from HDF5 file.
1693: Fatal Error. Aborting at Unhandled Exception
1693: --------------------------------------------------------------------------
1693: MPI_ABORT was invoked on rank 0 in communicator MPI_COMM_WORLD
1693: with errorcode 1.
1693: 
1693: NOTE: invoking MPI_ABORT causes Open MPI to kill all MPI processes.
1693: You may or may not see output from other processes, depending on
1693: exactly when Open MPI kills them.
1693: --------------------------------------------------------------------------
1/1 Test #1693: deterministic-input_check_bad_splineh5-1-1 ...   Passed    1.37 sec

@prckent
Copy link
Contributor

prckent commented Sep 26, 2023

Test this please

Copy link
Contributor

@markdewing markdewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks okay to me.

@ye-luo ye-luo merged commit 4490c4a into QMCPACK:develop Sep 27, 2023
38 of 39 checks passed
@ye-luo ye-luo deleted the refine-spline-error branch September 27, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants