Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify template parameters of BsplineAllocator and remove an unused variable in a unit test #5186

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Sep 25, 2024

Proposed changes

  1. Simplify template parameters of BsplineAllocator
  2. Resolve the last warning about "&input"
    https://cdash.qmcpack.org/viewBuildError.php?type=1&buildid=12897

What type(s) of changes does this code introduce?

  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc-server

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted

@ye-luo
Copy link
Contributor Author

ye-luo commented Sep 25, 2024

Test this please

@ye-luo
Copy link
Contributor Author

ye-luo commented Sep 25, 2024

Test this please

@ye-luo ye-luo changed the title Remove unused template parameter and variable Simplify template parameters of BsplineAllocator and remove an unused variable in a unit test Sep 25, 2024
@ye-luo
Copy link
Contributor Author

ye-luo commented Sep 25, 2024

Test this please

@prckent prckent merged commit 6d2cfde into QMCPACK:develop Sep 25, 2024
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants