Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QMCPACK prefix to ERROR and WARNING #5191

Merged
merged 4 commits into from
Sep 28, 2024

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Sep 27, 2024

Proposed changes

When libraries spit out recoverable "ERROR" message, ctest considers the run failed.
So it is better to prefix our ERROR and WARNING with QMCPACK.
I hit this issue when running ctest on Aurora due to MPICH "ERROR".

  1. I also fixed the rebind function in SYCL allocators as I did in 2dd1b0b although no code was affected.
  2. make deterministic-diamondC_2x1x1_pp-dmcbatch_sdj_excited-1-1-ionion pass in mixed precision.
  3. address clang warning about ambiguous "else"

deterministic tests.

100% tests passed, 0 tests failed out of 1034

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Aurora

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@ye-luo
Copy link
Contributor Author

ye-luo commented Sep 27, 2024

Test this please

@prckent prckent merged commit be28206 into QMCPACK:develop Sep 28, 2024
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants