Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make convert4qmc compatible with DIRAC versions > 22 #5196

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

camelto2
Copy link
Contributor

@camelto2 camelto2 commented Oct 7, 2024

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Updates converter to be compatible with DIRAC versions > 22.

What type(s) of changes does this code introduce?

Delete the items that do not apply

  • New feature

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

mac

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • Yes. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@camelto2 camelto2 changed the title make convert4qmc compatible with DIRAC versions > 22 [WIP] make convert4qmc compatible with DIRAC versions > 22 Oct 7, 2024
@camelto2 camelto2 changed the title [WIP] make convert4qmc compatible with DIRAC versions > 22 make convert4qmc compatible with DIRAC versions > 22 Oct 7, 2024
@ye-luo
Copy link
Contributor

ye-luo commented Oct 7, 2024

Test this please

@ye-luo ye-luo enabled auto-merge October 7, 2024 22:46
@ye-luo ye-luo merged commit 0e0275b into QMCPACK:develop Oct 8, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants