typo #1
Merged
typo #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. |
zieckey
added a commit
that referenced
this pull request
Mar 17, 2017
zieckey
added a commit
that referenced
this pull request
Mar 25, 2017
zieckey
added a commit
that referenced
this pull request
Apr 14, 2017
…unning_.
So we can precisely define the status of EventLoop. When the listening thread
is going to stop of the HTTP server, the working thread may still is running
and may call QueueInLoop() to dispatch HTTP response to the listening thread.
That will crash at :
#0 evpp::PipeEventWatcher::Notify (this=0x0) at evpp/event_watcher.cc:177
#1 evpp::EventLoop::QueueInLoop(...) evpp/event_loop.cc:237
zieckey
added a commit
that referenced
this pull request
Apr 27, 2017
zieckey
added a commit
that referenced
this pull request
Apr 27, 2017
…unning_.
So we can precisely define the status of EventLoop. When the listening thread
is going to stop of the HTTP server, the working thread may still is running
and may call QueueInLoop() to dispatch HTTP response to the listening thread.
That will crash at :
#0 evpp::PipeEventWatcher::Notify (this=0x0) at evpp/event_watcher.cc:177
#1 evpp::EventLoop::QueueInLoop(...) evpp/event_loop.cc:237
Open
zieckey
added a commit
that referenced
this pull request
May 20, 2017
zieckey
added a commit
that referenced
this pull request
May 20, 2017
…unning_.
So we can precisely define the status of EventLoop. When the listening thread
is going to stop of the HTTP server, the working thread may still is running
and may call QueueInLoop() to dispatch HTTP response to the listening thread.
That will crash at :
#0 evpp::PipeEventWatcher::Notify (this=0x0) at evpp/event_watcher.cc:177
#1 evpp::EventLoop::QueueInLoop(...) evpp/event_loop.cc:237
zieckey
added a commit
that referenced
this pull request
May 20, 2017
zieckey
added a commit
that referenced
this pull request
May 20, 2017
…unning_.
So we can precisely define the status of EventLoop. When the listening thread
is going to stop of the HTTP server, the working thread may still is running
and may call QueueInLoop() to dispatch HTTP response to the listening thread.
That will crash at :
#0 evpp::PipeEventWatcher::Notify (this=0x0) at evpp/event_watcher.cc:177
#1 evpp::EventLoop::QueueInLoop(...) evpp/event_loop.cc:237
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.