-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sessions changes #87
Sessions changes #87
Conversation
reviewed prematurely. should have sign off from SMEs
I think we can take this opportunity to restructure the page a bit, so topics related to how session works are grouped together. For example:
|
I'm totally on board with that. Do you want me to get rid of the session details section? I see that it's mentioned in the summary, so I'm going to put the summary after the session details section |
Session details section is still needed, since that's how people find out about the TTLs. I was debating if we should move everything code related to |
...
It seems like there's a 4th way a session is closed: The context manager is exited and all session jobs are finished. Right? Because it will be ended immediately after the jobs are done without the session reaching the max timeout value or reaching the interactive timeout value. |
It's the same as calling
|
I think that makes sense - I can rearrange. |
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
In that section we tell them how to change the maximum execution time though. Don't we still want that? I could delete the Defaults section if we really don't want to tell them (https://docs.quantum-computing.ibm.com/run/max-execution-time#defaults) We tell them how to set mac time in run-jobs-in-session, so we deleted this section, including the defaults. |
Co-authored-by: Jessie Yu <jessieyu@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @beckykd!
closes Qiskit#124 Changes from these PRs: - [x] 1 min TTL: ***REMOVED*** and ***REMOVED*** (request from @mriedem - instead of documenting this change, just tell users to look up the TTL from the session) - [x] Get session details: ***REMOVED*** (see ***REMOVED*** - [x] Limit max TTL per plan: ***REMOVED*** - [x] Accepting jobs flag: ***REMOVED*** - [x] The UI is also changing: ***REMOVED*** FYI - @jyu00 and @mriedem - [x] Need to clearly state that these changes are for qiskit-ibm-runtime version >= 0.13.0 No longer in scope: - [ ] Extended sessions: ***REMOVED*** and ***REMOVED*** This epic should contain all of the Sessions changes: ***REMOVED*** --------- Co-authored-by: Jessie Yu <jessieyu@us.ibm.com> Co-authored-by: abbycross <across@us.ibm.com>
closes #124