Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying input / output directories when building website #667

Merged
merged 13 commits into from
Feb 5, 2024

Conversation

frankharkins
Copy link
Member

Summary

Beforehand, these were hard-coded. Now you can install the ecosystem package from this repo, then run:

ecosystem build --resources ecosystem/resources --output website

frankharkins and others added 4 commits February 5, 2024 13:37
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
@frankharkins frankharkins marked this pull request as ready for review February 5, 2024 14:10
ecosystem/cli/website.py Outdated Show resolved Hide resolved

Ex: `python manager.py website build_website`
def _load_from_file(resources_dir: Path):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return type would be nice, but NBD

Copy link
Member Author

@frankharkins frankharkins Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, added in a33d22a

EDIT: not quite, fixed in a5a07e7

manager.py Show resolved Hide resolved
frankharkins and others added 5 commits February 5, 2024 14:24
@frankharkins frankharkins merged commit 20e9a85 into main Feb 5, 2024
4 checks passed
@Eric-Arellano Eric-Arellano deleted the FH/make-installable branch February 5, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants