Record syntax error instead of panicing when no block found #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, if we expect a block, beginning with `{`, the parser panics.
Now it logs an appropriate syntax error.
It could use better recovery. Because later errors are logged which
essentially say the same thing. But analyzing the cases for recovery
my take a bit of logic.
Closes #107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, if we expect a block, beginning with
{, the parser panics. Now it logs an appropriate syntax error.It could use better recovery. Because later errors are logged which essentially say the same thing. But analyzing the cases for recovery may take a bit of logic.
Closes #107