Redesign gate call modifiers, and other things #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
listed below. 1. Redesign modified gate calls. In the AST modifiers are represented as a `Vec` of modifiers in a field in the `GateCall` struct. A similar structure is used in `oq3_parser`. 2. Fix parsing gate call with HW qubit as first arg. For example `h $0` now parses correctly Fixes #84 3. Require parens around conditions in `if` and `while` statements. Parens around these conditions are demanded by the spec. 4. Remove cruft and unused tags and identifiers that are not caught by compiler, clippy, and QA tools.
jlapeyre
added a commit
that referenced
this pull request
Jan 31, 2024
This release fixes a few bugs and reworks how gate modifiers are implemented. Gate modifiers are represented in the ASG as a field in `GateCall` containing a Vec of modifiers. * The change since the last version 0.0.6 is in a single PR: #86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to work quickly, this PR does a few things. Some of which are
listed below.
Redesign modified gate calls. In the AST modifiers are represented as a
Vecof modifiers in a field in theGateCallstruct.A similar structure is used in
oq3_parser.Fix parsing gate call with HW qubit as first arg. For example
h $0now parses correctlyFixes Physical qubit identifiers do not work in gate calls #84
Require parens around conditions in
ifandwhilestatements. Parens around these conditions are demanded by the spec.Remove cruft and unused tags and identifiers that are not caught by compiler, clippy, and QA tools.