Rename "ch" method to "extended_stabilizer" #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atilag
approved these changes
Apr 2, 2019
| #pragma omp parallel for if(num_states_ > omp_threshold_ && num_threads_ > 1) num_threads(num_threads_) | ||
| for(uint_t i=0; i<num_states_; i++) | ||
| for(int_t i=0; i<END; i++) |
There was a problem hiding this comment.
I'd rather having a static_cast<int_t>(num_states_) than using another variable with different semantic meaningEND != num_states_
dcmckayibm
pushed a commit
to dcmckayibm/qiskit-aer
that referenced
this pull request
Nov 3, 2019
Rename "ch" method to "extended_stabilizer"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
"ch"QasmSimulatormethod to more descriptive"extended_stabilizer"method and updates options and tests to use this new convention.CH::RunnerOpenMP loops to be compatible with windows OpenMP 2.0.@padraic-padraic I can't add you as a reviewer here, but could you look at these changes?
Details and comments