Fixes in qubitvector #126
Merged
Fixes in qubitvector #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhorii
reviewed
Apr 5, 2019
| if (mat[1] == 0.0 && mat[2] == 0.0) { | ||
| const cvector_t diag = {{mat[0], mat[3]}}; | ||
| apply_diagonal_matrix(qubit, diag); | ||
| } |
1 task
dcmckayibm
pushed a commit
to dcmckayibm/qiskit-aer
that referenced
this pull request
Nov 3, 2019
* fix apply_matrix2 vectorization order * add check if 1-qubit mat in apply_matrix * fix indexes lambda functions * add qubit checks for apply_matrix2 etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds several fixes to
QubitVectorclass:apply_matrixchecks if matrix is single-qubit and if so uses optimized functionapply_matrixchecks if matrix is diagonal and if so uses optimized functionapply_matrix2using row-major order instead of col-major order for matrixDetails and comments