add fusion optimization for qasm simulator #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhorii
changed the title
There was a problem hiding this comment.
Thanks @hhorii, overall it looks good! My comments are mostly suggestions for renaming things to make it a little easier for others to understand what's going on.
Some more general comments:
- Could you add the
apply_matrix_sequencefunction to theunitary_statesince it can support it (though inheritance from QubitVector) - Could you add the basic_optimizations to the statevector_controller and unitary_controller since they would both benefit from the gate fusion too.
chriseclectic
previously approved these changes
Apr 19, 2019
There was a problem hiding this comment.
LGTM! @atilag did you want to review as well or can we merge?
|
@hhorii looks like something changed with the tests. As soon as you can get them passing we can merge |
chriseclectic
approved these changes
Apr 20, 2019
gadial
pushed a commit
to gadial/qiskit-aer
that referenced
this pull request
Apr 22, 2019
* add fusion * Set configuration to circuit optimization * add fusion options * disable fusion without configuration * add noise test cases and remove debug codes * delete statevector_gate_opt configuration * refactor fusion optimization for future optimization * qubitvector expands matrixes for fusion.
dcmckayibm
pushed a commit
to dcmckayibm/qiskit-aer
that referenced
this pull request
Nov 3, 2019
* add fusion * Set configuration to circuit optimization * add fusion options * disable fusion without configuration * add noise test cases and remove debug codes * delete statevector_gate_opt configuration * refactor fusion optimization for future optimization * qubitvector expands matrixes for fusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a basic optimization to aggregate gates in qasm simulator.
Details and comments
Some consecutive gates are aggregated with this optimization.
Available backend_options:
fusion_enable: enable fusion optimization withTrue(default:False).fusion_max_qubit: set maximum number of qubits for an aggregated operation.fusion_verbose: output optimized circuitsfusion_threshold: minimum number of qubits of circuits to enable this optimization.Will remain: supports fusion of large unitary