Fix symbol resolution misbehaior for GCC and Clang on MacOS #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseclectic
approved these changes
Apr 18, 2019
gadial
pushed a commit
to gadial/qiskit-aer
that referenced
this pull request
Apr 22, 2019
dcmckayibm
pushed a commit
to dcmckayibm/qiskit-aer
that referenced
this pull request
Nov 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to what we have fixed in PR #144 but seems like GCC and Clang disagrees in how to behave for
-flat_namepsaceon MacOS. So I only need to set this flag on GCC but not in Clang, because if I set this in Clang, the the loader loads the symbol from the first loaded library (exactly the same as if I don't set this flag in GCC)... :(Details and comments