Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with Failure simulations handling #167

Merged
merged 4 commits into from
Apr 24, 2019

Conversation

atilag
Copy link
Member

@atilag atilag commented Apr 23, 2019

Summary

When a simulation fails for whatever reason, the result object (or Qobj) doesn't have a results field, so we have to properly deal with this scenario.

Details and comments

@atilag atilag requested a review from chriseclectic April 23, 2019 18:15
Copy link
Member

@chriseclectic chriseclectic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@chriseclectic chriseclectic merged commit e25aaae into master Apr 24, 2019
@chriseclectic chriseclectic deleted the fix-simulation-failure-handling branch April 30, 2019 20:17
dcmckayibm pushed a commit to dcmckayibm/qiskit-aer that referenced this pull request Nov 3, 2019
* Fix an issue with Failure simulations handling

* Add tests for simple Success and Failure simulation events by mocking simulators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants