Implement AerDensityMatrix #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhorii
reviewed
Feb 28, 2023
|
|
||
| self._result = None | ||
| self._configs = configs | ||
|
|
There was a problem hiding this comment.
Suggested change
| def seed(self, value=None): | |
| """Set the seed for the quantum state RNG.""" | |
| if value is None or isinstance(value, int): | |
| self._aer_state.set_seed(value) | |
| else: | |
| raise AerError(f'This seed is not supported: type={value.__class__}, value={value}') | |
seed method is missing.
There was a problem hiding this comment.
I had overlooked this. So Terra's QuantumState.seed is called and the effect of the call to seed() in test_aer_densitymatrix.py is inadequate. OK, I will fix this as you suggested.
Comment on lines
181
to
184
| aer_state = AerState(**self._aer_state.configuration()) | ||
| aer_state.initialize(self._data, copy=False) | ||
| samples = aer_state.sample_memory(qubits, shots) | ||
| aer_state.close() |
There was a problem hiding this comment.
Suggested change
| aer_state = AerState(**self._aer_state.configuration()) | |
| aer_state.initialize(self._data, copy=False) | |
| samples = aer_state.sample_memory(qubits, shots) | |
| aer_state.close() | |
| self._aer_state.close() | |
| self._aer_state.renew() | |
| self._aer_state.initialize(self._data, copy=False) | |
| samples = self._aer_state.sample_memory(qubits, shots) | |
| self._data = self._aer_state.move_to_ndarray() |
To keep a random generator in AerState, sample_memory needs the same AerState instance.
There was a problem hiding this comment.
Thank you. I will correct it according to your suggestion and #1663.
hhorii
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a PR to implement AerDensityMatrix, which is a fine-tuned version of #1676.
Details and comments
When this PR is approved, #1676 should be closed at the same time.