-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add optional labels to standard gates #175
Merged
chriseclectic
merged 11 commits into
Qiskit:master
from
chriseclectic:feature-gate-labels
Apr 29, 2019
Merged
add optional labels to standard gates #175
chriseclectic
merged 11 commits into
Qiskit:master
from
chriseclectic:feature-gate-labels
Apr 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseclectic
force-pushed
the
feature-gate-labels
branch
from
April 26, 2019 22:03
e799f74
to
46b4967
Compare
allows a different noise model to be assigned to a standard gate by specifying a different label (like with unitaries).
chriseclectic
force-pushed
the
feature-gate-labels
branch
from
April 29, 2019 17:20
e07a5fc
to
b85685f
Compare
dcmckayibm
pushed a commit
to dcmckayibm/qiskit-aer
that referenced
this pull request
Nov 3, 2019
* add optional labels to standard gates in cpp noise model * allow labels for gates in python noise model * rename operations to instructions in NoiseModel * move test_noise_transformation * add add_basis_gates function to NoiseModel * add basis_gates to NoiseModel init * add id to NoiseModel default basis_gates * add to_instruction method to QuantumError * fix rounding errors in QuantumError composition * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
gate
operations. This allows adding a noise model to specially labeled gates as with theunitary
instruction in the noise model.NOTE: this isn't supported through Terra circuits yet, this is to preemptively to add support to Aer from the qobj level.
Details and comments
If a qobj circuit had instructions:
[{"name": "id", "qubits": [0]}, {"name": "id", "qubits": [0], "label": "alt_id"}]
then adding a noise model with quantum errorerror_a
to"id"
anderror_b
to"alt_id"
would sample from the two different errors for each of the identity instructions.Example